Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10057#discussion_r48210724
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkCuratorUtil.scala ---
@@ -35,8 +35,11 @@ private[spark] object SparkCuratorUtil extends Logging {
def newClient(
conf: SparkConf,
zkUrlConf: String = "spark.deploy.zookeeper.url"): CuratorFramework
= {
--- End diff --
You meant the param zkUrlConf? It feels like a good abstraction so that the
url configuration can at least be overriden right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
