Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8200#discussion_r48227861
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
 ---
    @@ -464,6 +465,24 @@ object OptimizeIn extends Rule[LogicalPlan] {
     }
     
     /**
    +  * Convert an expression into its conjunctive normal form (CNF), i.e. AND 
of ORs.
    +  * For example, a && b || c is normalized to (a || c) && (b || c) by this 
method.
    +  *
    +  * Refer to https://en.wikipedia.org/wiki/Conjunctive_normal_form for 
more information
    +  */
    +object CNFNormalization extends Rule[LogicalPlan] {
    --- End diff --
    
    Actually come to think of it, it'd be great to be able to turn on/off 
optimization rules for testing. Most of these can be undocumented.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to