GitHub user XD-DENG opened a pull request:
https://github.com/apache/spark/pull/10434
we should have training and test sets
I split the parsed data into two sets for training and testing separately.
I guess the original author didn't consider this so that everyone can
re-produce the result. But I think it would be better to have training set and
test set, since this is a quite common concept in machine learning and
beginners may get confused if we don't consider this.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/XD-DENG/spark patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/10434.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10434
----
commit 5fde8ab50898421062a4a1c637e16e2f68921148
Author: Xiaodong <xd_d...@hotmail.com>
Date: 2015-12-22T15:01:17Z
we should have training and test sets
I split the parsed data into two sets for training and testing separately.
I guess the original author didn't consider this so that everyone can
re-produce the result. But I think it would be better to have training set and
test set, since this is a quite common concept in machine learning and
beginners may get confused if we don't consider this.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
