Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10440#discussion_r48302701
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
 ---
    @@ -126,7 +125,7 @@ private[spark] class MesosClusterScheduler(
       private val retainedDrivers = conf.getInt("spark.mesos.retainedDrivers", 
200)
       private val maxRetryWaitTime = 
conf.getInt("spark.mesos.cluster.retry.wait.max", 60) // 1 minute
       private val schedulerState = engineFactory.createEngine("scheduler")
    -  private val stateLock = new ReentrantLock()
    --- End diff --
    
    It's not necessary to use `ReentrantLock` here since we only use 
`synchronized`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to