Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10438#discussion_r48324053
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1709,6 +1709,28 @@ private[spark] object Utils extends Logging {
}
/**
+ * Terminates a process waiting for at most the specified duration.
Returns whether
+ * the process terminated.
+ */
+ def terminateProcess(process: Process, timeoutMs: Long): Option[Int] = {
+ try {
+ // Java8 added a new API which will more forcibly kill the process.
Use that if available.
+ val destroyMethod = process.getClass().getMethod("destroyForcibly");
+ destroyMethod.setAccessible(true)
+ destroyMethod.invoke(process)
+ } catch {
+ case e: Exception => {
--- End diff --
in general catch NonFatal, i.e.
```scala
case NonFatal(e) => process.destroy()
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
