Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10443#discussion_r48350913
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala
---
@@ -241,7 +241,7 @@ case class NewInstance(
$javaType ${ev.value} = ${ctx.defaultValue(dataType)};
if ($argsNonNull) {
${ev.value} = $constructorCall;
- ${ev.isNull} = false;
+ ${ev.isNull} = ${ev.value} == null;
--- End diff --
Actually it's a irrelevant change and I forgot to revert it before push
commits.
The reason I made this change is: if we think a constructor may return
null, why we skip the null check in `propagateNull = true` branch? If @marmbrus
think this change makes sense, we should also set the `nullalble` to true.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
