Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10465#discussion_r48402502 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala --- @@ -159,8 +159,8 @@ class DataFrameReader private[sql](sqlContext: SQLContext) extends Logging { * @param columnName the name of a column of integral type that will be used for partitioning. * @param lowerBound the minimum value of `columnName` used to decide partition stride * @param upperBound the maximum value of `columnName` used to decide partition stride - * @param numPartitions the number of partitions. the range `minValue`-`maxValue` will be split - * evenly into this many partitions + * @param numPartitions the number of partitions, the range `lowerBound`-`upperBound` will be --- End diff -- grammatically speaking the change is incorrect? I don't think you can change the period to comma. The other change looks good.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org