Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/10368#discussion_r48507734
--- Diff:
core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala ---
@@ -109,6 +111,9 @@ class KryoSerializer(conf: SparkConf)
kryo.register(classOf[SerializableJobConf], new KryoJavaSerializer())
kryo.register(classOf[HttpBroadcast[_]], new KryoJavaSerializer())
kryo.register(classOf[PythonBroadcast], new KryoJavaSerializer())
+ kryo.register(classOf[TaskMetrics], new KryoJavaSerializer())
+ kryo.register(classOf[DirectTaskResult[_]], new KryoJavaSerializer())
+ kryo.register(classOf[IndirectTaskResult[_]], new KryoJavaSerializer())
--- End diff --
bq. people may forget to register new classes if they just add an Option
field to TaskMetrics in future
Addition to TaskMetrics would be reviewed, right ?
A comment can be added to TaskMetrics reminding them to register
corresponding class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
