GitHub user rxin opened a pull request:

    https://github.com/apache/spark/pull/10501

    [SPARK-12547][SQL] Tighten scala style checker enforcement for UDF 
registration

    We use scalastyle:off to turn off style checks in certain places where it 
is not possible to follow the style guide. This is usually ok. However, in udf 
registration, we disable the checker for a large amount of code simply because 
some of them exceed 100 char line limit. It is better to just disable the line 
limit check rather than everything.
    
    In this pull request, I only disabled line length check, and fixed a 
problem (lack explicit types for public methods).


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rxin/spark SPARK-12547

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/10501.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #10501
    
----
commit 5157f276a68eef3eebf70df66ee526f1529ac354
Author: Reynold Xin <r...@databricks.com>
Date:   2015-12-29T02:40:04Z

    [SPARK-12547][SQL] Tighten scala style checker enforcement for UDF 
registration.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to