Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9581#discussion_r48631929
--- Diff: python/pyspark/ml/param/shared.py ---
@@ -603,19 +603,19 @@ class HasSolver(Params):
"""
# a placeholder to make it appear in the generated doc
- solver = Param(Params._dummy(), "solver", "the solver algorithm for
optimization. If this is not set or empty, default value is 'auto'.")
+ solver = Param(Params._dummy(), "solver", "the solver algorithm for
optimization. If this is not set or empty, default value is 'auto'.", str)
def __init__(self):
super(HasSolver, self).__init__()
#: param for the solver algorithm for optimization. If this is not
set or empty, default value is 'auto'.
- self.solver = Param(self, "solver", "the solver algorithm for
optimization. If this is not set or empty, default value is 'auto'.")
+ self.solver = Param(self, "solver", "the solver algorithm for
optimization. If this is not set or empty, default value is 'auto'.", str)
self._setDefault(solver='auto')
def setSolver(self, value):
"""
Sets the value of :py:attr:`solver`.
"""
- self._paramMap[self.solver] = value
+ self._set(**{"solver": value})
--- End diff --
Why not this one?
```
self._set(solver=value)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
