Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1346#discussion_r14903645
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala 
---
    @@ -85,6 +85,26 @@ object ScalaReflection {
         case t if t <:< definitions.BooleanTpe => Schema(BooleanType, nullable 
= false)
       }
     
    +  def typeOfObject: PartialFunction[Any, DataType] = {
    +    // The data type can be determined without ambiguity.
    +    case obj: BooleanType.JvmType => BooleanType
    +    case obj: BinaryType.JvmType => BinaryType
    +    case obj: StringType.JvmType => StringType
    +    case obj: ByteType.JvmType => ByteType
    +    case obj: ShortType.JvmType => ShortType
    +    case obj: IntegerType.JvmType => IntegerType
    +    case obj: LongType.JvmType => LongType
    +    case obj: FloatType.JvmType => FloatType
    +    case obj: DoubleType.JvmType => DoubleType
    +    case obj: DecimalType.JvmType => DecimalType
    +    case obj: TimestampType.JvmType => TimestampType
    +    case null => NullType
    +    // For other cases, there is no obvious mapping from the type of the 
given object to a
    --- End diff --
    
    Perhaps this should go in scaladoc for this partial function.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to