Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10274#discussion_r48805155
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -86,6 +86,22 @@ private[ml] class WeightedLeastSquares(
val aaBar = summary.aaBar
val aaValues = aaBar.values
+ if (bStd == 0) {
+ if (fitIntercept) {
+ logWarning(s"The standard deviation of the label is zero, so the
coefficients will be " +
+ s"zeros and the intercept will be the mean of the label; as a
result, " +
+ s"training is not needed.")
+ val coefficients = new DenseVector(Array.ofDim(k-1))
+ val intercept = bBar
+ val diagInvAtWA = new DenseVector(Array(0D))
+ return new WeightedLeastSquaresModel(coefficients, intercept,
diagInvAtWA)
+ }
+ else {
--- End diff --
move `else` up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
