Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/10580#discussion_r48808612
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2005,13 +2005,18 @@ setMethod("saveDF",
#' saveAsTable(df, "myfile")
#' }
setMethod("saveAsTable",
- signature(df = "DataFrame", tableName = "character", source =
"character",
- mode = "character"),
+ signature(df = "DataFrame", tableName = "character"),
function(df, tableName, source = NULL, mode="error", ...){
if (is.null(source)) {
- sqlContext <- get(".sparkRSQLsc", envir = .sparkREnv)
- source <- callJMethod(sqlContext, "getConf",
"spark.sql.sources.default",
- "org.apache.spark.sql.parquet")
+ if (exists(".sparkRSQLsc", envir = .sparkREnv)) {
+ sqlContext <- get(".sparkRSQLsc", envir = .sparkREnv)
+ } else if (exists(".sparkRHivesc", envir = .sparkREnv)) {
+ sqlContext <- get(".sparkRHivesc", envir = .sparkREnv)
+ } else {
+ stop("sparkRHive or sparkRSQL context has to be specified")
+ }
+ source <- callJMethod(sqlContext, "getConf",
"spark.sql.sources.default",
+ "org.apache.spark.sql.parquet")
}
allModes <- c("append", "overwrite", "error", "ignore")
# nolint start
--- End diff --
Yes, let's merge with PR #10584 to unblock SparkR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
