Github user hhbyyh commented on the pull request: https://github.com/apache/spark/pull/9614#issuecomment-168935901 @avulanov Thanks for review. The only possible concern I got is LBFGSOptimizer/SGDOptimizer appears to be getter, yet they are setters. I sent an update which changes the function name only.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org