Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10585#discussion_r48828840
--- Diff: core/src/main/scala/org/apache/spark/scheduler/StageInfo.scala ---
@@ -61,6 +61,21 @@ class StageInfo(
"running"
}
}
+
+ private[spark] def getStatusDetail: String = {
--- End diff --
Is this used elsewhere or can it just go into `SparkListener`?
I think this is confusing as one big format string. I'd make `val`s for the
pieces that need some computation and return one big interpolated string. Also
this is verbose:
```
foo match {
Some(x) => f(x)
case _ => ""
}
```
compared to just `foo.map(x => f(x)).getOrElse("")`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
