Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9858#discussion_r48873698
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
    @@ -361,8 +361,15 @@ private[sql] abstract class SparkStrategies extends 
QueryPlanner[SparkPlan] {
           case r @ logical.Range(start, end, step, numSlices, output) =>
             execution.Range(start, step, numSlices, r.numElements, output) :: 
Nil
           case logical.RepartitionByExpression(expressions, child, 
nPartitions) =>
    -        execution.Exchange(HashPartitioning(
    -          expressions, nPartitions.getOrElse(numPartitions)), 
planLater(child)) :: Nil
    +        val newPartitioning = HashPartitioning(expressions, 
nPartitions.getOrElse(numPartitions))
    +        val childPlan = self.sqlContext.planner.planLater(child)
    +        // This is necessary to get the outputPartitioning from 
EnsureRequirements batch
    +        val executedChildPlan = 
sqlContext.prepareForExecution.execute(childPlan)
    --- End diff --
    
    Why is this not just:
    ```scala
    val childPlan = planLater(child)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to