Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10606#discussion_r48911600
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java
---
@@ -99,7 +99,11 @@ public UnsafeInMemorySorter(
this.consumer = consumer;
this.memoryManager = memoryManager;
this.sorter = new Sorter<>(UnsafeSortDataFormat.INSTANCE);
- this.sortComparator = new SortComparator(recordComparator,
prefixComparator, memoryManager);
+ if (recordComparator != null) {
--- End diff --
`recordComparator` is nullable? That's surprising to me. If
`recordComparator` is null, does that also imply that `prefixComparator` is
null? Can we put `@Nullable` annotations on the parameter so that IntelliJ's
fancy nullability handling checks work properly?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
