Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10498#discussion_r48951242
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala ---
@@ -351,7 +365,18 @@ abstract class OutputWriterFactory extends
Serializable {
*
* @since 1.4.0
*/
- def newInstance(path: String, dataSchema: StructType, context:
TaskAttemptContext): OutputWriter
+ def newInstance(
+ path: String,
+ dataSchema: StructType,
+ context: TaskAttemptContext): OutputWriter
+
+ // TODO: expose bucket API to users.
+ private[sql] def newInstance(
+ path: String,
+ bucketId: Option[Int],
--- End diff --
use `Option[Int]` so that this method can support both bucketing and
non-bucketing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
