Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10618#discussion_r48984926
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -224,7 +224,8 @@ private[ui] class AllJobsPage(parent: JobsTab) extends
WebUIPage("") {
}
val formattedDuration = duration.map(d =>
UIUtils.formatDuration(d)).getOrElse("Unknown")
val formattedSubmissionTime =
job.submissionTime.map(UIUtils.formatDate).getOrElse("Unknown")
- val jobDescription = UIUtils.makeDescription(lastStageDescription,
parent.basePath)
+ val basePathUri = UIUtils.prependBaseUri(parent.basePath)
+ val jobDescription = UIUtils.makeDescription(lastStageDescription,
basePathUri)
val detailUrl =
"%s/jobs/job?id=%s".format(UIUtils.prependBaseUri(parent.basePath), job.jobId)
--- End diff --
If you wanted to clean up the code slightly, you could change this to use
`basePathUri` defined above, then wrap it back to a single line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
