Github user NarineK commented on a diff in the pull request:
https://github.com/apache/spark/pull/9667#discussion_r48998009
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/optimization/GradientDescent.scala
---
@@ -122,8 +122,8 @@ class GradientDescent private[spark] (private var
gradient: Gradient, private va
* @return solution vector
*/
@DeveloperApi
- def optimize(data: RDD[(Double, Vector)], initialWeights: Vector):
Vector = {
- val (weights, _) = GradientDescent.runMiniBatchSGD(
+ def optimize(data: RDD[(Double, Vector)], initialWeights: Vector):
(Vector, Double, Integer) = {
--- End diff --
sure, I can add a new method optimizeWithStats. How about if the
optimizeWithStats returns an Object OptimizeStats which contains all those 3
fields? @jkbradley
Later OptimizeStats can be extended ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
