Github user marmbrus commented on the pull request:

    https://github.com/apache/spark/pull/10128#issuecomment-169524856
  
    How does this make a difference in join selection?  I think the logic in 
`ExtractEquiJoinKeys` is already smart enough to do this correctly.  Even if 
that was not the case we should not mix concerns here.  Rules should be kept as 
simple as possible to avoid bugs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to