Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10649#discussion_r49125905
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystQl.scala ---
@@ -41,16 +41,9 @@ private[sql] class CatalystQl(val conf: ParserConf =
SimpleParserConf()) {
}
}
-
- /**
- * Returns the AST for the given SQL string.
- */
- protected def getAst(sql: String): ASTNode = ParseDriver.parse(sql, conf)
-
- /** Creates LogicalPlan for a given HiveQL string. */
- def createPlan(sql: String): LogicalPlan = {
+ protected def safeParse[T](sql: String, ast: ASTNode, toResult: ASTNode
=> T): T = {
--- End diff --
use multi parameter list?
```scala
protected def safeParse[T](sql: String, ast: ASTNode)(toResult: ASTNode =>
T): T
```
then you can call it in a slightly nicer way
```scala
safeParse(sql, ParseDriver.parseExpression(sql, conf)) { ast =>
...
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
