Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1094#discussion_r14936355
  
    --- Diff: 
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala
 ---
    @@ -132,4 +135,17 @@ object YarnSparkHadoopUtil {
         }
       }
     
    +  def getUIHistoryAddress(sc: SparkContext, conf: SparkConf) : String = {
    +    val eventLogDir = sc.eventLogger match {
    +      case Some(logger) => logger.logDir.split("/").last
    --- End diff --
    
    I think it would be better to add a routine to the eventLogger to just give 
us the name of the directory rather then us splitting it and it possibly 
breaking in the future.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to