Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10587#discussion_r49174933
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -1089,6 +1097,14 @@ abstract class RDD[T: ClassTag](
* and one operation for merging two U's, as in scala.TraversableOnce.
Both of these functions are
* allowed to modify and return their first argument instead of creating
a new U to avoid memory
* allocation.
+ *
+ * @param zeroValue the initial value for the accumulated result of each
partition for the seqOp
+ * operator, and also the initial value for the combine
results from different
+ * partitions for the conbOp operator.
+ * - this will typically be the neutral element.
--- End diff --
There are some typos now, like conbOp instead of combOp. Also there's a
dangling phrase in both starting with "-" which is supposed to join the
previous sentence? while you're here you can back-tick `Nil`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
