Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10674#issuecomment-170247768 Yeah I think this is correct. The comment that was here previously suggested this was related to use of `Optional` in the public API, but I think it needs to stay in compile scope for the shading to work as desired. If there are no other thoughts today I'll merge
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org