Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/10685#discussion_r49280447
--- Diff:
external/flume-sink/src/main/scala/org/apache/spark/streaming/flume/sink/Logging.scala
---
@@ -26,20 +26,20 @@ import org.slf4j.{Logger, LoggerFactory}
private[sink] trait Logging {
// Make the log field transient so that objects with Logging can
// be serialized and used on another machine
- @transient private var log_ : Logger = null
--- End diff --
We can't write like `log_: Logger`. So, can we rename those vars to which
starts with `_`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
