Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10688#discussion_r49285986
--- Diff: project/MimaBuild.scala ---
@@ -91,11 +91,16 @@ object MimaBuild {
def mimaSettings(sparkHome: File, projectRef: ProjectRef) = {
val organization = "org.apache.spark"
+ // The resolvers setting for MQTT Repository is needed for
mqttv3(1.0.1)
+ // because spark-streaming-mqtt(1.6.0) depends on it.
+ // Remove the setting on updating previousSparkVersion.
val previousSparkVersion = "1.6.0"
val fullId = "spark-" + projectRef.project + "_2.10"
mimaDefaultSettings ++
Seq(previousArtifact := Some(organization % fullId %
previousSparkVersion),
- binaryIssueFilters ++= ignoredABIProblems(sparkHome, version.value))
+ binaryIssueFilters ++= ignoredABIProblems(sparkHome, version.value),
+ sbt.Keys.resolvers :=
+ Seq("MQTT Repository" at
"https://repo.eclipse.org/content/repositories/paho-releases";))
--- End diff --
I wonder if you have to add this to `defaultResolvers` instead in order for
it to take effect? Also, you might want to `+=` rather than `:=` to avoid
completely overwriting the existing resolvers, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
