Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10520#discussion_r49359695
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveShim.scala 
---
    @@ -123,6 +126,24 @@ private[hive] object HiveShim {
         // for Serialization
         def this() = this(null)
     
    +    override def hashCode(): Int = {
    +        if (instance != null && instance.isInstanceOf[GenericUDFMacro]) {
    --- End diff --
    
    Hive's macro is kind of special. I do not think users can use a class that 
extends GenericUDFMacro (You can take a look at hive's function registry. Macro 
registration is handled by registerMacro.). 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to