Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/10476#discussion_r49408849 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -287,6 +288,17 @@ object ColumnPruning extends Rule[LogicalPlan] { } /** + * Combines the adjacent [[Project]] and [[Join]] operators, iff their output sets are the same. + */ +object CombineProjectJoin extends Rule[LogicalPlan] { + + def apply(plan: LogicalPlan): LogicalPlan = plan transformUp { + case p @ Project(_, j: Join) + if j.outputSet == p.outputSet => j --- End diff -- @cloud-fan I did a try, but it touches a lot of codes. We need to add a new parameter `projectList` into `Join`. I am not sure if this is a right direction. What do you think? As what @rxin said, we might can do that for all the operators. That means, we need to add a new parameter `projectList` into all the operators.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org