Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/10469#discussion_r49408907 --- Diff: python/pyspark/ml/util.py --- @@ -52,3 +71,141 @@ def _randomUID(cls): concatenates the class name, "_", and 12 random hex chars. """ return cls.__name__ + "_" + uuid.uuid4().hex[12:] + + +@inherit_doc +class MLWriter(object): + """ + Abstract class for utility classes that can save ML instances. + + .. versionadded:: 2.0.0 + """ + + def __init__(self, instance): + self._jwrite = instance._java_obj.write() + + @since("2.0.0") + def save(self, path): --- End diff -- This method will need to copy Params over to the JVM model. Please also update the doc test to test for some parameter value to make sure Params get copied.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org