Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/10376#discussion_r49662917
--- Diff:
core/src/test/scala/org/apache/spark/shuffle/sort/BypassMergeSortShuffleWriterSuite.scala
---
@@ -104,7 +104,7 @@ class BypassMergeSortShuffleWriterSuite extends
SparkFunSuite with BeforeAndAfte
new Answer[(TempShuffleBlockId, File)] {
override def answer(invocation: InvocationOnMock):
(TempShuffleBlockId, File) = {
val blockId = new TempShuffleBlockId(UUID.randomUUID)
- val file = File.createTempFile(blockId.toString, null, tempDir)
+ val file = new File(tempDir, blockId.name)
--- End diff --
Because `File.createTempFile()` will create an empty file even if you don't
use it, so this will break the current changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
