Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/10186#discussion_r49677569
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala ---
@@ -119,6 +121,9 @@ final class ChiSqSelectorModel private[ml] (
/** list of indices to select (filter). Must be ordered asc */
val selectedFeatures: Array[Int] = chiSqSelector.selectedFeatures
+ /** Java-friendly version of [[selectedFeatures]]. */
+ def javaSelectedFeatures: java.util.List[Int] =
selectedFeatures.toSeq.asJava
--- End diff --
This isn't needed for Java, so I'd make it a private API. But hopefully we
can remove this altogether once [https://github.com/apache/spark/pull/10724]
gets merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
