Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/10472#discussion_r49679366
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/BinaryClassificationEvaluator.scala
---
@@ -29,6 +29,7 @@ import org.apache.spark.sql.types.DoubleType
/**
* :: Experimental ::
* Evaluator for binary classification, which expects two input columns:
rawPrediction and label.
+ * The rawPrediction column can be of type double or vector.
--- End diff --
How about a little more explicit:
```The rawPrediction column can be of type double (binary 0/1 prediction,
or probability of label 1) or of type vector (length-2 vector of raw
predictions, scores, or label probabilities).```
Also, could you please update the Python class doc with the same text?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
