Github user skyluc commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10701#discussion_r49733021
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
 ---
    @@ -318,7 +319,7 @@ private[spark] class MesosClusterScheduler(
         ready = false
         metricsSystem.report()
         metricsSystem.stop()
    -    mesosDriver.stop(true)
    +    mesosDriver.stop(driverFailOver)
    --- End diff --
    
    Instead of killing without failover, we could also start it without 
failover.
    
    In the `start` method, to use:
    ```scala
    val driver = createSchedulerDriver(
           master,
           MesosClusterScheduler.this,
           Utils.getCurrentUserName(),
           appName,
           conf,
           Some(frameworkUrl),
           Some(driverFailOver),                                 // <-- with or 
without checkpoint data
           Some(if (driverFailOver) Double.MaxValue else 0.0),   // <-- timeout 
for failover recovery
           fwId)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to