Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/10593#discussion_r49764984
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/UnsafeRowParquetRecordReader.java
---
@@ -154,6 +184,45 @@ public float getProgress() throws IOException,
InterruptedException {
return (float) rowsReturned / totalRowCount;
}
+ /**
+ * Returns the ColumnarBatch object that will be used for all rows
returned by this reader.
+ * This object is reused. Calling this enables the vectorized reader. It
is not valid to
+ * call nextKeyValue/nextBatch before calling this.
+ */
+ public ColumnarBatch resultBatch() {
+ return resultBatch(DEFAULT_OFFHEAP);
--- End diff --
The default is false so doing what you are suggesting. I think in a follow
up PR, I'm going to turn this into an enum, the boolean is confusing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
