Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10731#discussion_r49961674
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -438,11 +438,25 @@ class Analyzer(
}
j.copy(right = newRight)
}
-
// When resolve `SortOrder`s in Sort based on child, don't report
errors as
// we still have chance to resolve it based on grandchild
- case s @ Sort(ordering, global, child) if child.resolved &&
!s.resolved =>
- val newOrdering = resolveSortOrders(ordering, child, throws =
false)
+ case s @ Sort(ordering, global, child) if child.resolved =>
--- End diff --
Should we keep the `&& !s.resolved` in the condition and have another case
to handle the case of all literals?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
