Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/10788#discussion_r49961906
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -247,10 +247,30 @@ class LogisticRegression @Since("1.2.0") (
@Since("1.5.0")
override def getThresholds: Array[Double] = super.getThresholds
- override protected def train(dataset: DataFrame):
LogisticRegressionModel = {
- // Extract columns from data. If dataset is persisted, do not persist
oldDataset.
+ private var optInitialWeights: Option[Vector] = None
+ /** @group setParam */
+ private[spark] def setInitialWeights(value: Vector): this.type = {
+ this.optInitialWeights = Some(value)
+ this
+ }
--- End diff --
So we have setInitialWeights on StreamingLogisticRegressionWithSGD - would
it be better to have it match StreamingLogisticRegressionWithSGD ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
