Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10800#discussion_r49965701
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVParameters.scala
---
@@ -44,9 +44,9 @@ private[sql] case class CSVParameters(parameters:
Map[String, String]) extends L
}
}
- val delimiter = CSVTypeCast.toChar(parameters.getOrElse("delimiter",
","))
+ val seq = CSVTypeCast.toChar(parameters.getOrElse("seq", ","))
--- End diff --
I think it is "sep", not "seq".
Also I like the old name for the variable better. We should just rename the
name for the option. And for backward compatibility, we should accept
"delimiter" if "sep" is not set.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
