Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10723#discussion_r49974486
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -52,26 +130,30 @@ private[sql] class SparkQl(conf: ParserConf =
SimpleParserConf()) extends Cataly
nodeToDescribeFallback(node)
} else {
tableType match {
- case Token("TOK_TABTYPE", Token("TOK_TABNAME", nameParts ::
Nil) :: Nil) =>
+ case Token("TOK_TABTYPE", Token("TOK_TABNAME", nameParts) ::
Nil) =>
nameParts match {
- case Token(".", dbName :: tableName :: Nil) =>
+ case Token(dbName, _) :: Token(tableName, _) :: Nil =>
// It is describing a table with the format like
"describe db.table".
// TODO: Actually, a user may mean tableName.columnName.
Need to resolve this
// issue.
- val tableIdent = extractTableIdent(nameParts)
+ val tableIdent = TableIdentifier(
+ cleanIdentifier(tableName),
Some(cleanIdentifier(dbName)))
datasources.DescribeCommand(
UnresolvedRelation(tableIdent, None), isExtended =
extended.isDefined)
- case Token(".", dbName :: tableName :: colName :: Nil) =>
+ case Token(dbName, _) :: Token(tableName, _) ::
Token(colName, _) :: Nil =>
// It is describing a column with the format like
"describe db.table column".
nodeToDescribeFallback(node)
- case tableName =>
+ case tableName :: Nil =>
// It is describing a table with the format like
"describe table".
datasources.DescribeCommand(
UnresolvedRelation(TableIdentifier(tableName.text),
None),
--- End diff --
cleanIdentifier?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
