Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10807#discussion_r50090823
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
@@ -714,12 +714,20 @@ class StreamingContext private[streaming] (
// interrupted. See SPARK-12001 for more details. Because the
body of this case can be
// executed twice in the case of a partial stop, all methods
called here need to be
// idempotent.
- scheduler.stop(stopGracefully)
--- End diff --
My interpretation of the purpose was a little different. If cleanup
involves running A, B and C, then we want B and C to try to run even if A
fails. I didn't think we necessarily expected the caller to re-try `stop()`
since I don't think that's usual. Yes, a fatal error will still cause the whole
thing to stop but in my mind a fatal error means lots of bets are off. This is
also for consistency with how `SparkContext.stop()` works.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
