Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/10085#discussion_r50160074
--- Diff: python/pyspark/ml/feature.py ---
@@ -135,9 +135,9 @@ class Bucketizer(JavaTransformer, HasInputCol,
HasOutputCol):
"specified will be treated as errors.")
@keyword_only
- def __init__(self, splits=None, inputCol=None, outputCol=None):
+ def __init__(self, splits=None, inputCol=None, outputCol=None,
_java_model=None):
--- End diff --
Oh yah, I think the original plan was to avoid the overhead of object
creation and sending the params back to the JVM if it is supplied since we
already had a transformer. I'll remove this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
