Github user aarondav commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1450#discussion_r15040327
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala 
---
    @@ -214,7 +214,7 @@ class PairRDDFunctions[K, V](self: RDD[(K, V)])
           throw new SparkException("reduceByKeyLocally() does not support 
array keys")
         }
     
    -    def reducePartition(iter: Iterator[(K, V)]): Iterator[JHashMap[K, V]] 
= {
    +    val reducePartition = (iter: Iterator[(K, V)]) => {
    --- End diff --
    
    And when I said non-obvious, I mean just from looking at the function name 
and input arguments. Here it is actually straightforward to infer from the 
remaining lines, but in other situations it is less so.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to