Github user mgummelt commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10370#discussion_r50300018
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
 ---
    @@ -440,6 +446,9 @@ private[spark] class MesosClusterScheduler(
             .mkString(",")
           options ++= Seq("--py-files", formattedFiles)
         }
    +    desc.schedulerProperties
    +      .filter { case (key, _) => !replicatedOptionsBlacklist.contains(key) 
}
    +      .foreach { case (key, value) => options ++= Seq("--conf", 
s"""$key="$value"""") }
    --- End diff --
    
    Are lines 437-443 now redundant?  If setting --total-executor-cores is 
identical to --conf spark.cores.max, then we don't need to set both.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to