Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9946#issuecomment-173402547
Actually, what's the difference between letting `main` complete normally
(in which case `java` already exits with status 0 right?) and exiting
explicitly at the end of main with status 0? You still get shutdown hooks but
`System.exit` kills the non-daemon threads?
I see you're saying it isn't really a behavior change. In the scenario
here, the JVM would still be running because some non-daemon thread is alive,
so how does YARN decide to forcibly kill it -- it's because the app has already
told YARN it's done but hasn't completed?
There still seems to be a material difference between always immediately
killing threads at the end, and maybe getting killed some short time later,
since the former will always occur in normal operation. Could we emulate the
delay as well as better-than-nothing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
