Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/8734#discussion_r50361275
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala ---
@@ -740,7 +740,7 @@ private[ml] object RandomForest extends Logging {
val categoryStats =
binAggregates.getImpurityCalculator(nodeFeatureOffset,
featureValue)
val centroid = if (categoryStats.count != 0) {
- categoryStats.predict
+ categoryStats.prob(categoryStats.predict)
--- End diff --
Finding the _proportion_ falling in outcome class 1 simply requires
division of the counts by a constant. Since we're just using that number for an
ordering, constant division won't matter. They are the same.
My initial comment has a typo. It should say for a "binary **outcome**",
not "binary category".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
