Github user iyounus commented on the pull request:

    https://github.com/apache/spark/pull/10702#issuecomment-173738254
  
    I've added an exception for the case when label is constant and 
`standardization == true` and `regParam != 0.0`. Also added test for this case.
    
    I cannot test the case when `standardizeLabel = false` with non-zero 
`regParam` against analytic normal equation solution, because the analytic 
normal equation gives me quite different results.
    
    Even for the case when `regParam=0` and `fitIntercept=false`, the results 
from normal equation are slightly different from `glmnet` and `spark`. Please 
see my detailed comment regarding this comparison at 
https://github.com/apache/spark/pull/10274.
    
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to