Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10845#issuecomment-173853848 @viirya rather than me pointing out all the problem in each iteration, can you try figuring out all the corner cases yourself and then submit this for review? Thanks.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org