Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10911#discussion_r50786480
--- Diff:
common/sketch/src/main/java/org/apache/spark/util/sketch/CountMinSketchImpl.java
---
@@ -347,8 +356,10 @@ public void writeTo(OutputStream out) throws
IOException {
public static CountMinSketchImpl readFrom(InputStream in) throws
IOException {
DataInputStream dis = new DataInputStream(in);
- // Ignores version number
- dis.readInt();
+ int version = dis.readInt();
+ if (version != Version.V1.getVersionNumber()) {
+ throw new IOException("Unexpected Count-Min Sketch version number "
+ version);
--- End diff --
might be better to put it in parentheses, i.e. "version number (15)".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
