Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10911#discussion_r50797694
--- Diff:
common/sketch/src/main/java/org/apache/spark/util/sketch/CountMinSketchImpl.java
---
@@ -368,4 +379,30 @@ public static CountMinSketchImpl readFrom(InputStream
in) throws IOException {
return new CountMinSketchImpl(depth, width, totalCount, hashA, table);
}
+
+ @Override
+ public void writeExternal(ObjectOutput out) throws IOException {
+ try (ByteArrayOutputStream bos = new ByteArrayOutputStream()) {
+ this.writeTo(bos);
+ byte[] bytes = bos.toByteArray();
+ out.writeObject(bytes);
+ }
+ }
+
+ @Override
+ public void readExternal(ObjectInput in) throws IOException,
ClassNotFoundException {
+ byte[] bytes = (byte[]) in.readObject();
+
+ try (ByteArrayInputStream bis = new ByteArrayInputStream(bytes)) {
+ CountMinSketchImpl sketch = CountMinSketchImpl.readFrom(bis);
+
+ this.depth = sketch.depth;
--- End diff --
it'd be good to refactor this so we don't need to assign the variables. one
way is to take the serialization/deserialization code out of readFrom into a
function.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
