Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10835#discussion_r50804115
--- Diff: core/src/main/scala/org/apache/spark/scheduler/Task.scala ---
@@ -141,6 +136,18 @@ private[spark] abstract class Task[T](
def executorDeserializeTime: Long = _executorDeserializeTime
/**
+ * Collect the latest values of accumulators used in this task. If the
task failed,
+ * filter out the accumulators whose values should not be included on
failures.
+ */
+ def collectAccumulatorUpdates(taskFailed: Boolean = false):
Seq[AccumulableInfo] = {
+ if (context != null) {
--- End diff --
Just curious: under which circumstances would this method be called when
`context == null`? Would that only happen if `run()` failed immediately before
TaskContext initialization?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
